fix: handle missing tool_call.id in runTools for providers#1946
Closed
anishesg wants to merge 1 commit into
Closed
fix: handle missing tool_call.id in runTools for providers#1946anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
Some providers do not populate the `tool_call.id` field when returning tool calls, or may set it to an empty string. When the SDK's `AbstractChatCompletionRunner._runTools()` method constructs tool result messages to send back to the API, it uses this empty or missing `tool_call_id`, which causes the API to reject the request with a 400 status code. Signed-off-by: anish <anishesg@users.noreply.github.com>
1 task
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e91393f9bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some providers do not populate the
tool_call.idfield when returning tool calls, or may set it to an empty string. When the SDK'sAbstractChatCompletionRunner._runTools()method constructs tool result messages to send back to the API, it uses this empty or missingtool_call_id, which causes the API to reject the request with a 400 status code.This fix adds a defensive fallback in
AbstractChatCompletionRunner.tsat line 346. Whentool_call.idis missing or empty, the function name is used as thetool_call_idinstead. This ensures that tool result messages always have a valid identifier, preventing the 400 error while maintaining compatibility with all providers.Fixes #1528